Skip to content

Conversation

@andrewgos
Copy link
Collaborator

@andrewgos andrewgos commented Dec 19, 2025

Description

Pulling in latest refactor tokens -> Adjusted the style dictionary script -> Regenerate css -> Apply to the button component

Related Jira or GitHub Issue

https://moodle.atlassian.net/browse/MDS-379

Type of Change

  • Feature
  • Bugfix
  • Refactor
  • Documentation
  • Other (please describe)

Screenshots/Previews

N/A

Checklist

  • I have updated, added, and run tests such as JSUnit, Storybook interactions, or fuzzing to prove my fix is effective or that my feature works
  • I have updated or added Storybook stories for new or changed components (if appropriate)
  • I have considered accessibility and described any improvements or issues
  • I have considered security implications and referenced SECURITY.md if relevant

Additional Notes

N/A

@andrewgos andrewgos requested review from a team as code owners December 19, 2025 09:59
@andrewgos andrewgos force-pushed the MDS-379-refactor-tokens branch from 08c140d to 2f0b2db Compare December 19, 2025 10:07
@andrewgos andrewgos changed the title chore(tokens): Pulled refactored tokens and regenerate css chore(tokens): Sync the latest refactored tokens and regenerate css Dec 19, 2025
@andrewgos andrewgos changed the title chore(tokens): Sync the latest refactored tokens and regenerate css chore(tokens): Sync to the latest refactored tokens and regenerate css Dec 19, 2025
@andrewgos andrewgos force-pushed the MDS-379-refactor-tokens branch from 2f0b2db to f20ad4f Compare December 24, 2025 03:58
dist/
storybook-static/
tokens/
../../tokens/
Copy link
Collaborator Author

@andrewgos andrewgos Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @Chocolate-lightning : not sure why, but i need to do the relative path for this particular file (since we moved it to .github/linters) to make the ignore working

@andrewgos
Copy link
Collaborator Author

andrewgos commented Dec 24, 2025

The Button component has been updated to match the latest tokens, but a few items that I need designers to confirm:

  • Some outline backgrounds have default colors for the hover, but some still have hover colors for the hover. Is this intended?
  • Some outlines text colors using variables that doesnt exists ie. fg/primary/default
  • Some outlines text colors using the primitives instead of the border color. Is this intended?
  • Some outlines background using the bg- colors but some are on border- colors, is this intended?

cc @borisbasque @barbararamiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants