Skip to content

tape: add pause/resume and loop control with threading improvements #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tehn merged 6 commits into from
Sep 8, 2025
Merged

tape: add pause/resume and loop control with threading improvements #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b5f419f
tape: expose loop control and add OSC setter
colinmcardell Aug 25, 2025
1a1c394
tape: add pause/resume with threading improvements
colinmcardell Aug 28, 2025
edfc3c5
tape: add input validation to pause controls in weaver
colinmcardell Sep 3, 2025
1f6297d
tape: add draft updates to tape.lua integrating addition of pause/res…
colinmcardell Sep 4, 2025
574a93a
fileselect: add preview debounce; cancel clocks on exit
colinmcardell Sep 6, 2025
3cd531f
tape: add loop icon and update playback UI layout
colinmcardell Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crone/osc-methods.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,12 @@ osc methods:
/poll/stop/cut/phase []
/tape/record/open [s]
/tape/record/start []
/tape/record/pause [i]
/tape/record/stop []
/tape/play/open [s]
/tape/play/start []
/tape/play/pause [i]
/tape/play/stop []
/tape/play/loop [i]
/set/level/tape [f]
/set/level/tape_rev [f]
12 changes: 12 additions & 0 deletions crone/src/MixerClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ class MixerClient : public Client<6, 6> {
tape.writer.start();
}

void pauseTapeRecord(bool paused) {
tape.pauseRecord(paused);
}

void stopTapeRecord() {
tape.writer.stop();
}
Expand All @@ -149,9 +153,17 @@ class MixerClient : public Client<6, 6> {
tape.reader.start();
}

void pauseTapePlayback(bool paused) {
tape.pausePlayback(paused);
}

void stopTapePlayback() {
tape.reader.stop();
}

void setTapeLoop(bool loop) {
tape.setLooping(loop);
}
};
} // namespace crone

Expand Down
21 changes: 21 additions & 0 deletions crone/src/OscInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,6 +960,13 @@ void OscInterface::addServerMethods() {
mixerClient->startTapeRecord();
});

addServerMethod("/tape/record/pause", "i", [](lo_arg **argv, int argc) {
if (argc < 1) {
return;
}
mixerClient->pauseTapeRecord(argv[0]->i != 0);
});

addServerMethod("/tape/record/stop", "", [](lo_arg **argv, int argc) {
(void)argv;
(void)argc;
Expand All @@ -979,12 +986,26 @@ void OscInterface::addServerMethods() {
mixerClient->startTapePlayback();
});

addServerMethod("/tape/play/pause", "i", [](lo_arg **argv, int argc) {
if (argc < 1) {
return;
}
mixerClient->pauseTapePlayback(argv[0]->i != 0);
});

addServerMethod("/tape/play/stop", "", [](lo_arg **argv, int argc) {
(void)argv;
(void)argc;
mixerClient->stopTapePlayback();
});

addServerMethod("/tape/play/loop", "i", [](lo_arg **argv, int argc) {
if (argc < 1) {
return;
}
mixerClient->setTapeLoop(argv[0]->i != 0);
});

addServerMethod("/set/level/tape", "f", [](lo_arg **argv, int argc) {
if (argc < 1) {
return;
Expand Down
Loading