Skip to content

Propagate timeout errors to callback. #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Propagate timeout errors to callback. #1761

wants to merge 3 commits into from
+22 −15

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Jul 7, 2025

@vbabanin vbabanin requested a review from a team as a code owner July 7, 2025 05:08
@vbabanin vbabanin requested review from NathanQingyangXu and removed request for a team July 7, 2025 05:08
NathanQingyangXu
NathanQingyangXu reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some uncertainties that neeed author's response

@vbabanin vbabanin self-assigned this Jul 7, 2025
@vbabanin vbabanin requested a review from NathanQingyangXu July 8, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanQingyangXu NathanQingyangXu NathanQingyangXu approved these changes

Assignees

@vbabanin vbabanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbabanin @NathanQingyangXu