Update default review priority tag #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
matthewdale
reviewed
Aug 5, 2025
| @@ -1,4 +1,4 @@ | |||
| priority-3-low: | |||
| review-priority-normal: | |||
There was a problem hiding this comment.
Do we want the default priority to be normal or low?
There was a problem hiding this comment.
The idea is to have normal as the default priority, with low and urgent being explicit choices:
- review-priority-low - not time sensitive; review within 3 business days. Use for non-prioritized changes, e.g. build system changes that aren't blocking anyone
- review-priority-normal (default) - aim to review within 24 hours, ideally on same day if pull request comes in before lunch
- review-priority-urgent - urgent; review immediately. Only use after prior coordination. Nits and non-blocking review comments should be deferred to a follow-up pull request for an expedited merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The review priority tags were recently renamed and thus need to be updated in the labeler config.