DOCSP-49237: bson vector subtype #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
comandeo-mongo
requested changes
May 22, 2025
rachel-mack
approved these changes
May 22, 2025
source/data-formats/bson.txt
Outdated
Comment on lines
480
to
482
| You can convert ``Vector`` and array objects to ``BSON::Binary`` objects | ||
| so they are serialized as BSON binary vector (subtype 9) instances. Use | ||
| the ``Binary.from_vector`` method, as shown in the following code: |
There was a problem hiding this comment.
You could include a link back up to the BSON:Binary section (maybe overkill)
But does the the list of valid subtypes from the Binary section need to be updated to include :vector as a possible type? Might be a good opportunity to review the list for completeness.
comandeo-mongo
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49237
Staging Links
Self-Review Checklist