-
Notifications
You must be signed in to change notification settings - Fork 88
(DOCSP-15010): Using Change Listeners In Your Components - React Native SDK #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-15010): Using Change Listeners In Your Components - React Native SDK #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, lots of minor nitpicks and questions since I'm not super familiar with React.
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
...n/using-change-listeners-class-component.codeblock.using-change-listeners-class-component.js
Outdated
Show resolved
Hide resolved
Co-authored-by: nate contino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of wording nits and a suggestion for code sample maintenance!
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
source/sdk/react-native/examples/use-change-listeners-in-components.txt
Outdated
Show resolved
Hide resolved
…nents.txt Co-authored-by: nate contino <[email protected]>
…nents.txt Co-authored-by: nate contino <[email protected]>
…nents.txt Co-authored-by: nate contino <[email protected]>
f14a1b7
to
a5c2006
Compare
Pull Request Info
Jira
Staged Changes (Requires MongoDB Corp SSO)
Review Guidelines
REVIEWING.md