Skip to content

DOCSP-51123: CC edits and cleanup #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 2, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jul 1, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51123

Staging Links

  • aggregation
  • connect
  • data-formats/modeling-bson-data
  • get-started
  • monitoring-logging/monitoring
  • security
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?
    • Did you add redirects?

    Copy link

    netlify bot commented Jul 1, 2025

    Deploy Preview for docs-php-library ready!

    Name Link
    🔨 Latest commit 2d6a52c
    🔍 Latest deploy log https://app.netlify.com/projects/docs-php-library/deploys/68654fd2a37f870008cbdc1b
    😎 Deploy Preview https://deploy-preview-279--docs-php-library.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 1, 2025

    🔄 Deploy Preview for docs-php-library processing

    Item Details
    🔨 Latest Commit d4f27d7568c27cf2c24675f84a0c9c1a3af094f9
    😎 Deploy Preview https://deploy-preview-279--docs-php-library.netlify.app
    🔍 Build Logs View Logs

    @rustagir rustagir self-requested a review July 2, 2025 14:38
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm, w/ one question about the TLS content

    @@ -411,6 +411,30 @@ connection to your MongoDB instance:

    To learn more about the {+stable-api+}, see the :ref:`php-stable-api` guide.
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: out of scope of this PR but should all of the TLS content go in its own page in the specify options drawer? I have seen this TOC org in other drivers

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I put TLS in the Security drawer based on the unified toc spreadsheet. But I should move this content anyway (to the Security landing page)

    @@ -9,7 +9,7 @@

    $options = [
    'tls' => true,
    'tlsCAFile' => '/path/to/ca.pem'
    'tlsCAFile' => '/path/to/ca.pem' ,
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    'tlsCAFile' => '/path/to/ca.pem' ,
    'tlsCAFile' => '/path/to/ca.pem',

    @norareidy norareidy merged commit 1af97bc into mongodb:comp-cov Jul 2, 2025
    8 of 9 checks passed
    @norareidy norareidy deleted the DOCSP-51123-cleanup branch July 2, 2025 17:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants