-
Notifications
You must be signed in to change notification settings - Fork 34
DOCSP-51123: CC edits and cleanup #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-php-library processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, w/ one question about the TLS content
@@ -411,6 +411,30 @@ connection to your MongoDB instance: | |||
|
|||
To learn more about the {+stable-api+}, see the :ref:`php-stable-api` guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: out of scope of this PR but should all of the TLS content go in its own page in the specify options drawer? I have seen this TOC org in other drivers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put TLS in the Security drawer based on the unified toc spreadsheet. But I should move this content anyway (to the Security landing page)
@@ -9,7 +9,7 @@ | |||
|
|||
$options = [ | |||
'tls' => true, | |||
'tlsCAFile' => '/path/to/ca.pem' | |||
'tlsCAFile' => '/path/to/ca.pem' , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'tlsCAFile' => '/path/to/ca.pem' , | |
'tlsCAFile' => '/path/to/ca.pem', |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-51123
Staging Links
Self-Review Checklist