Skip to content

DOCSP-50220: Break up FAQ #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jun 23, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50220

Staging Links

  • connect/client
  • connect/connection-targets
  • get-started
  • index
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?
    • Did you add redirects?

    Copy link

    netlify bot commented Jun 23, 2025

    Deploy Preview for docs-php-library ready!

    Name Link
    🔨 Latest commit 4d95767
    🔍 Latest deploy log https://app.netlify.com/projects/docs-php-library/deploys/685c56d89ee9b80008246f57
    😎 Deploy Preview https://deploy-preview-276--docs-php-library.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jun 23, 2025

    🔄 Deploy Preview for docs-php-library processing

    Item Details
    🔨 Latest Commit cdf345d61b8a21e54b1c8052008b6a3abd163a71
    😎 Deploy Preview https://deploy-preview-276--docs-php-library.netlify.app
    🔍 Build Logs View Logs

    Copy link
    Collaborator

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Two suggestions:

    Comment on lines 121 to 126
    Troubleshooting
    ---------------

    This section addresses issues that you might encounter when using a
    MongoDB client.

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think you could just make this a Client Persistence section and get rid of the Troubleshooting heading.

    Comment on lines 127 to 131
    Troubleshooting
    ---------------

    This section addresses issues that you might encounter when
    connecting to a MongoDB deployment.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Some comment, I think this can be a standalone Serve Selection Errors section.

    @norareidy
    Copy link
    Collaborator Author

    Note to tech reviewer: this PR doesn't include new content, it moves existing FAQ sections to other pages with copy edits. I'm just looking to confirm that it's still accurate!

    @norareidy norareidy requested review from a team and alcaeus and removed request for a team June 24, 2025 16:38
    Copy link
    Member

    @alcaeus alcaeus left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    One nitpick regarding named arguments, but LGTM!


    $client = new MongoDB\Client(
    uri: getenv('MONGODB_URI') ?: 'mongodb://127.0.0.1/',
    uriOptions: [],
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We can omit default values for parameters when using named arguments:

    Suggested change
    uriOptions: [],

    @norareidy norareidy merged commit 184797a into mongodb:comp-cov Jun 25, 2025
    6 of 7 checks passed
    @norareidy norareidy deleted the DOCSP-50220-faq-breakup branch June 25, 2025 20:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants