Skip to content

DOCSP-43912: Improve change stream code examples #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2025
Merged

DOCSP-43912: Improve change stream code examples #264

merged 7 commits into from
Jun 25, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jun 4, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43912

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2025 •
edited
Loading

✅ Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit dbe3a01
🔍 Latest deploy log https://app.netlify.com/projects/docs-php-library/deploys/685b61e437b7760008775b6b
😎 Deploy Preview https://deploy-preview-264--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lindseymoore
lindseymoore approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format LGTM!

@mcmorisi mcmorisi requested a review from GromNaN June 4, 2025 18:37
GromNaN
GromNaN requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change-streams.php cannot be run on its own as each change stream loop is an infinite loop (unless you drop the collection). Wouldn't is better to create separate files that we can run?

@mcmorisi mcmorisi requested a review from GromNaN June 10, 2025 13:59
GromNaN
GromNaN reviewed Jun 12, 2025
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced by the new style. Keeping the previous for loop, or replacing with a while(true) would be more comprehensible.

paulinevos
paulinevos reviewed Jun 23, 2025
View reviewed changes
@docs-builder-bot
Copy link

docs-builder-bot commented Jun 23, 2025 •
edited
Loading

🔄 Deploy Preview for docs-php-library processing

Item Details
🔨 Latest Commit a36e7079974e07d29aade7f79b98bbd523661557
😎 Deploy Preview https://deploy-preview-264--docs-php-library.netlify.app
🔍 Build Logs View Logs

@mcmorisi mcmorisi requested a review from GromNaN June 23, 2025 15:06
@mcmorisi mcmorisi merged commit 4129a38 into mongodb:master Jun 25, 2025
6 of 8 checks passed
@mcmorisi mcmorisi deleted the DOCSP-43912-fix-monitor-code branch June 25, 2025 20:11
mcmorisi added a commit that referenced this pull request Jun 25, 2025
@mcmorisi
DOCSP-43912: Improve change stream code examples (#264)
99c6300 
(cherry picked from commit 4129a38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulinevos paulinevos paulinevos left review comments

@GromNaN GromNaN GromNaN approved these changes

@lindseymoore lindseymoore lindseymoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcmorisi @docs-builder-bot @GromNaN @paulinevos @lindseymoore