DRIVERS-3232 Use ECR instead of artifactory and update to v3 #84
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
blink1073
changed the title
There was a problem hiding this comment.
zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found a couple of leftover instances of removed inputs. Might be worth checking to make sure all of them have been removed.
Can you also please create a DRIVERS ticket for this so we can ensure that all drivers migrate to v3 and have the relevant instructions handy?
| with: | ||
| filenames: dist/* | ||
| - name: Get the evergreen commit | ||
| id: evergreen-commit | ||
| shell: bash | ||
| run: | | ||
| echo "commit=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT | ||
| - uses: mongodb-labs/drivers-github-tools/full-report@v2 | ||
| - uses: mongodb-labs/drivers-github-tools/full-report@v3 |
There was a problem hiding this comment.
Can't comment on the actual line, but this action still uses the removed silk_asset_group input.
ruby/publish/action.yml
Outdated
| with: | ||
| filenames: '${{ env.GEM_FILE_NAME }}' | ||
|
|
||
| - name: Generate SSDLC Reports | ||
| uses: mongodb-labs/drivers-github-tools/full-report@v2 | ||
| uses: mongodb-labs/drivers-github-tools/full-report@v3 | ||
| with: | ||
| product_name: ${{ inputs.product_name }} | ||
| release_version: ${{ env.RELEASE_VERSION }} | ||
| dist_filenames: ${{ env.GEM_FILE_NAME }} | ||
| silk_asset_group: ${{ inputs.silk_asset_group }} |
blink1073
changed the title
|
I created https://jira.mongodb.org/browse/DRIVERS-3232 and made the suggested changes. |
|
@baileympearson I updated the node script to replace the usage of SILK_ASSET_GROUP with the new suggested workflow. Please let me know if that looks good to you. |
There was a problem hiding this comment.
@blink1073 Sorry for the delayed review. The changes LGTM and are passing in Node: https://github.com/mongodb/node-mongodb-native/actions/runs/16604710849/job/46973723525
|
@alcaeus friendly ping for final review |
Successful run: https://github.com/mongodb/pymongo-auth-aws/actions/runs/16452018217