[3.x] Fix binary checks (port of #15900) to make sure textual-ish files can be edited #15901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This adds a whitelist of mime types that should be editable. Port of #15900 for 3.x.
Also corrects the logic for calls to isFileBinary; a binary file is one that consists of garbage text and should not be edited, but that logic had been flipped in 3.x.
Why is it needed?
This check is used to decide wether or not the files tree should offer the edit option. Some of these, especially json and xml, are not offered the edit option regardless of exension.
How to test
Add a file with some JSON content, for example:
Note that in the files tree it is not editable (clicking it does nothing).
Apply the patch, and note that now it can be edited.
Related issue(s)/PR(s)
None, was reported in slack and I went straight from debugging to fixing.