Skip to content

Changed the default gravatar type #15406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Changed the default gravatar type #15406

merged 1 commit into from
Feb 23, 2021

Conversation

Ruslan-Aleev
Copy link
Collaborator

@Ruslan-Aleev Ruslan-Aleev commented Feb 22, 2021

What does it do?

Changed the default gravatar type.

If you don't have a gravatar, then by default a picture with the mm type was displayed:
gravatar_0

But other types of gravatar (for example, retro) allow you to generate unique images by email hash:
email 1
gravatar_1

email 2
gravatar_2

And you can immediately understand under which account you are in the manager panel, provided that the gravatar is enabled in the system settings (disabled by default).

Why is it needed?

UI / UX improvements

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 22, 2021
@Ruslan-Aleev Ruslan-Aleev added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed Pull request requires review and testing. labels Feb 22, 2021
@Ruslan-Aleev Ruslan-Aleev added this to the v3.0.0-alpha3 milestone Feb 22, 2021
@Ibochkarev Ibochkarev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Feb 23, 2021
@Ruslan-Aleev
Copy link
Collaborator Author

@opengeek If you have the desire and time, you can merge this commit into the 2.x branch, since in the 2nd branch gravatar is enabled by default. For the 2.x branch this will be more useful.

@opengeek opengeek merged commit 7913c2f into modxcms:3.x Feb 23, 2021
@Ruslan-Aleev Ruslan-Aleev deleted the 3.x-gravatar-type branch February 23, 2021 21:19
@rthrash rthrash removed the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants