Skip to content

[3.x] Improve the processor permission response error message #15403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2021
Merged

[3.x] Improve the processor permission response error message #15403

merged 3 commits into from
Feb 23, 2021

Conversation

Ibochkarev
Copy link
Collaborator

What does it do?

  • Add a lexicon entry for the processor permission message.
  • Output the permission and the processor action in the message (Moving the permission class property to the modProcessor class was needed).
  • Show the new error message in the MODx.combo.ComboBox loadexception

Why is it needed?

Port of #15402 from 2.x

How to test

See #15402

Related issue(s)/PR(s)

Port of #15402 from 2.x

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 21, 2021
@Ibochkarev Ibochkarev added this to the v3.0.0-alpha3 milestone Feb 21, 2021
@Ibochkarev Ibochkarev added proposal Proposal about improvement aka RFC. Need to be discussed before start implementation. pr/review-needed Pull request requires review and testing. labels Feb 21, 2021
@Ibochkarev Ibochkarev requested review from Jako and theboxer February 21, 2021 11:18
@Ibochkarev Ibochkarev changed the title [3.x] Improve the processor response error message [3.x] Improve the processor permission response error message Feb 21, 2021
@Ibochkarev Ibochkarev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Feb 22, 2021
@opengeek opengeek merged commit f2e0990 into modxcms:3.x Feb 23, 2021
@Ibochkarev Ibochkarev deleted the permission_errormessage branch February 23, 2021 21:08
@rthrash rthrash removed the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Apr 5, 2021
@theboxer theboxer mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jako Jako Jako approved these changes

@theboxer theboxer theboxer approved these changes

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. proposal Proposal about improvement aka RFC. Need to be discussed before start implementation.
Projects
None yet
Milestone
v3.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
5 participants
@Ibochkarev @Jako @theboxer @opengeek @rthrash