Skip to content

Conversation

BobRay
Copy link
Contributor

@BobRay BobRay commented Feb 6, 2021

Prevent PHP error when $_SESSION is not set (e.g., in a unit or acceptance test).

What does it do?

Sanity check for $_SESSION

Why is it needed?

Original code throws a PHP fatal error if $_SESSION is not set.

How to test

Related issue(s)/PR(s)

Issue: #15374

Prevent PHP error when $_SESSION is not set (e.g., in a unit or acceptance test).
@cla-bot
Copy link

cla-bot bot commented Feb 6, 2021

Thank you for your contribution! Before your pull request can be reviewed, please sign the MODX Contributor License Agreement (CLA). This is to make sure MODX has your written permission to distribute projects containing your contributions under the appropriate license.

Please make sure the CLA has been signed for GitHub user(s): @BobRay

Once you've signed, please reply with @cla-bot check to verify and update the status of this pull request.

@BobRay
Copy link
Contributor Author

BobRay commented Feb 6, 2021 via email

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 6, 2021
@cla-bot
Copy link

cla-bot bot commented Feb 6, 2021

The cla-bot has been summoned, and re-checked this pull request!

@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants