Add check that the file exists when uploading it #15264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibochkarev
approved these changes
Sep 22, 2020
theboxer
approved these changes
Sep 23, 2020
JoshuaLuckers
suggested changes
Oct 13, 2020
There was a problem hiding this comment.
Please add the system setting that's introduced in PR #15285.
|
@JoshuaLuckers I forgot about PR completely, added a setting, check :) |
JoshuaLuckers
previously requested changes
Feb 15, 2021
Comment on lines
1734
to
1741
| $settings['upload_file_exists']->fromArray(array ( | ||
| 'key' => 'upload_file_exists', | ||
| 'value' => '1', | ||
| 'xtype' => 'combo-boolean', | ||
| 'namespace' => 'core', | ||
| 'area' => 'file', | ||
| 'editedon' => null, | ||
| ), '', true, true); |
There was a problem hiding this comment.
Suggested change
| $settings['upload_file_exists']->fromArray(array ( | |
| 'key' => 'upload_file_exists', | |
| 'value' => '1', | |
| 'xtype' => 'combo-boolean', | |
| 'namespace' => 'core', | |
| 'area' => 'file', | |
| 'editedon' => null, | |
| ), '', true, true); | |
| $settings['upload_file_exists']->fromArray([ | |
| 'key' => 'upload_file_exists', | |
| 'value' => true, | |
| 'xtype' => 'combo-boolean', | |
| 'namespace' => 'core', | |
| 'area' => 'file', | |
| 'editedon' => null, | |
| ], '', true, true); |
|
I believe it's better to have the markup be part of the lexicon. |
opengeek
changed the title
opengeek
changed the title
opengeek
dismissed
JoshuaLuckers’s stale review
I believe the requested change was made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Same as in #15232 but for the 3.x branch.
Added a check for the existence of a file when uploading it.
In the current version, if the file names match, then the file will be overwritten.
Related issue(s)/PR(s)
#15232
#8371
#14641