Skip to content

Conversation

ScriptedAlchemy
Copy link
Member

Description

This pull request introduces several updates aimed at improving development workflows, modernizing dependencies, and enhancing project configurations. The most significant changes include migrating from npm to pnpm, adding new debugging configurations, and updating build dependencies and tasks.

Workflow Improvements:

  • Migrated all npm commands to pnpm in .vscode/launch.json to standardize the package manager across the project. This includes commands for running builds, tests, linting, and other tasks. Additionally, new debugging configurations (Debug Enhanced Tests, Debug Current Test File, Debug Package Tests, Debug All Tests) were added to streamline testing workflows.
  • Introduced a new task in .vscode/tasks.json for building the enhanced package using pnpm and Node.js v18, with support for NVM to ensure compatibility with the required Node version.

Dependency Updates:

  • Updated the packages/chrome-devtools/project.json to include a dependsOn property for the build target, ensuring dependencies are built in the correct order.
  • Removed @module-federation/utilities from the peerDependencies in packages/storybook-addon/package.json, potentially reducing unused dependencies.

Configuration Cleanup:

  • Removed .vscode/ from the .cursorignore file, likely to ensure that VS Code-specific configurations are included in the repository.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

netlify bot commented May 11, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 4080f52
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/68202599df2f7d0008f18d2c
😎 Deploy Preview https://deploy-preview-3761--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented May 11, 2025

🦋 Changeset detected

Latest commit: 4080f52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@module-federation/storybook-addon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review May 11, 2025 04:31
@ScriptedAlchemy ScriptedAlchemy merged commit 04d3064 into main May 11, 2025
17 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the ignores branch May 11, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant