fix(rsbuild-plugin): explicitly setting CORS headers #3635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to security concerns, starting with Rsbuild >= 1.3.0, the Rsbuild dev server will no longer set
Access-Control-Allow-Origin
to*
by default (web-infra-dev/rsbuild#4876).MF requires CORS headers, so I'll set that in
@module-federation/rsbuild-plugin
, which is the same as other plugins.It's worth noting that in my opinion this is still a temporary solution, and we should try to avoid using
*
as the default value. A safer default value is needed instead.Types of changes
Checklist