Skip to content

Conversation

chenjiahan
Copy link
Contributor

@chenjiahan chenjiahan commented Mar 26, 2025

Description

Due to security concerns, starting with Rsbuild >= 1.3.0, the Rsbuild dev server will no longer set Access-Control-Allow-Origin to * by default (web-infra-dev/rsbuild#4876).

MF requires CORS headers, so I'll set that in @module-federation/rsbuild-plugin, which is the same as other plugins.

It's worth noting that in my opinion this is still a temporary solution, and we should try to avoid using * as the default value. A safer default value is needed instead.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: 58b20d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 58b20d7
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67e3a4c8d2bc8d0008220a71
😎 Deploy Preview https://deploy-preview-3635--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1 2heal1 merged commit ed072f9 into module-federation:main Mar 27, 2025
17 checks passed
@danpeen danpeen mentioned this pull request Apr 1, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants