Skip to content

feat(dts-plugin): decode encoded remote name #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Jun 18, 2024

Description

if remote name start with ENCODE_NAME_PREFIX , it will be decoded.

This feature is used to support remote name which has @ and other characters which can not be used in var globalObject , and the name have to transformed.

take examples:

    new ModuleFederationPlugin({
       name:'@scope/button'
    });

encodeName('@scope/button',ENCODE_NAME_PREFIX) === 'ENCODE_NAME_PREFIXscope_scope__button'

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 9d87a6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@module-federation/webpack-bundler-runtime Patch
@module-federation/dts-plugin Patch
@module-federation/sdk Patch
@module-federation/enhanced Patch
@module-federation/runtime-tools Patch
@module-federation/manifest Patch
@module-federation/rspack Patch
@module-federation/devtools Patch
@module-federation/managers Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/runtime Patch
@module-federation/utilities Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
@module-federation/third-party-dts-extractor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 9d87a6b
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66713cf275479b0008130e55
😎 Deploy Preview https://deploy-preview-2626--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhoushaw zhoushaw merged commit 88900ad into main Jun 18, 2024
10 checks passed
@zhoushaw zhoushaw deleted the feat/decode-remote branch June 18, 2024 07:59
@2heal1 2heal1 mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants