Skip to content

Visual regression diff fix #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hklsiteimprove
Copy link
Contributor

@hklsiteimprove hklsiteimprove commented Dec 9, 2020

Problem

The generated artifacts for the failed and diff images couldn't be viewed.
The diff image was written both as the failed and as the diff.
The diff image was written incorrectly.

What I did

  1. Fixed bugs for diff and failed images generated by the visual-regression package

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2020

🦋 Changeset detected

Latest commit: bbe94a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-visual-regression Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hklsiteimprove hklsiteimprove force-pushed the visual-regression-diff-fix branch from aeabcfc to bbe94a2 Compare December 9, 2020 13:18
@LarsDenBakker LarsDenBakker merged commit c0633e4 into modernweb-dev:master Dec 9, 2020
@LarsDenBakker
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants