Skip to content

Conversation

kfischer-okarin
Copy link
Contributor

This is effectively reverting my two previous PRs #8 #42 and adding the missing capabilities for list changed notifications.

See the Discussion linked in Motivation and context for details.

Motivation and Context

See Discussion #57 for background

How Has This Been Tested?

I tried it out in the inspector

Breaking Changes

Not really - for the same reasoning as already mentioned in #8

This should not be a breaking change since an empty tool list and no capability should make no practical difference to a procotol conform MCP client.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The notification capabilities are not yet checked like the normal method capabilities - but that should be fixed in another PR I think (I will send that too later)

@kfischer-okarin kfischer-okarin changed the title Simplify capabilitiy handling and add missing capabilities Remove capability determination and add missing capabilities Jun 14, 2025
@kfischer-okarin kfischer-okarin changed the title Remove capability determination and add missing capabilities Remove automatic capability determination and add missing capabilities Jun 14, 2025
@kfischer-okarin kfischer-okarin force-pushed the simplify-and-add-missing-capabilities branch from 9658f59 to 2221470 Compare June 18, 2025 04:24
@atesgoral
Copy link
Contributor

This makes sense, especially after I went around digging for the root cause of an issue I ran into: I wasn't passing any tools at init, but calling define_tool for custom bindings. The capability magic doesn't kick in then. We could either forward fix that issue (should be simple) or go ahead with this explicit method.

@topherbullock @koic what do you think?

@atesgoral atesgoral mentioned this pull request Jul 11, 2025
9 tasks
@koic koic merged commit 1a89cc5 into modelcontextprotocol:main Jul 12, 2025
5 checks passed
@koic
Copy link
Member

koic commented Jul 12, 2025

Looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants