Validate ToolCall Args against Schema #43
Merged
+306
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit eeb287117535dfb43785704171625323f01d5bda)
topherbullock
previously approved these changes
Jun 5, 2025
koic
reviewed
Jun 6, 2025
tylerrowsell
force-pushed
the
tool-arg-validation
branch
from
6a3a6dc to
934a5e8
Compare
koic
reviewed
Jun 9, 2025
topherbullock
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Tool call arguments are not being validated against the schema. This ensures that the schema is valid and that the tool call args are valid. Otherwise it fails early.
There is an option to disable tool call validation.
How Has This Been Tested?
Yes. Tested on internal products.
Breaking Changes
Tool calls will be validated, if your application has tool calls coming in that don't match the schema these requests will now fail.
Types of changes
Checklist