Skip to content

feat: add "Copy JSON" button #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

fveiraswww
Copy link
Contributor

Motivation and Context

added a "Copy JSON" button so you don't have to manually select and copy the value. Even if you modify the content, you can still copy the full thing properly formatted with one click

How Has This Been Tested?

  • clicked the button
  • pasted the result
  • well formatted JSON

Breaking Changes

nope

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

tiny UX improvement

Screenshot 2025-06-27 at 5 28 39 PM

@cliffhall
Copy link
Member

Hi @fveiraswww!

Thanks for this. Would you mind adding a unit test to DynamicJsonForm.test.tsx?

@cliffhall cliffhall added the waiting on submitter Waiting for the submitter to provide more info label Jul 2, 2025
@fveiraswww
Copy link
Contributor Author

Hi @fveiraswww!

Thanks for this. Would you mind adding a unit test to DynamicJsonForm.test.tsx?

done ✅

@cliffhall
Copy link
Member

When first using this on Chrome, Firefox, or Safari, it disconnects and resets the Inspector.

Untitled.mov

@fveiraswww
Copy link
Contributor Author

When first using this on Chrome, Firefox, or Safari, it disconnects and resets the Inspector.

Untitled.mov

can you try again now? I pushed a fix, the button was submitting a form, which caused the window reload

changing it to type="button" seems to fix it

Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. No longer resets the app on click. Copies just fine.

LGTM! 👍

@cliffhall cliffhall merged commit b39528d into modelcontextprotocol:main Jul 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on submitter Waiting for the submitter to provide more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants