-
Notifications
You must be signed in to change notification settings - Fork 701
chore: Add node-version to package.json and workflows #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add node-version to package.json and workflows #473
Conversation
Hi @baruchiro! This seems nice, but I'd much rather use Docs for setup-node show how you can do this. (note, using In - uses: actions/setup-node@v5
with:
node-version-file: package.json
cache: npm and in {
"engines": {
"node": ">=22.0.0"
}
} |
@baruchiro Any interest in updating the PR to use package.json as the source of the version? I still think this is a good idea. |
… package.json for node version
@cliffhall updated. However, I have noticed the Dockerfile versions are |
@baruchiro Could you update the version to ( For reference, that value was set by this PR where the contributor said that an error was reported for versions less than 22.7.5. The problem was related to the Fetch API, and what I found was:
But to be safe, I'd keep it at |
Only needed in the package.json, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Added .node-version file and updated GitHub Actions workflows to use it for Node.js version management.