-
Notifications
You must be signed in to change notification settings - Fork 124
[DO NOT MERGE] Use stable 1.85.1 release #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
efcfe9f
to
0bc4755
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can we try to get even more of those commits into main
as indicated in my comments?
Thanks for taking a look @tautschnig! I'll check which of the changes can be committed in main. Note that the changes will still need to be made in the branch as well even if we merge them in main since the branch is created from a 2-months-old commit (bc134ce). Once the branch catches up with those changes in main, the diffs will become fewer. |
Yes, I made my comments with the idea that it'd be great to keep the diff to a minimum. |
Opened #3964 to make the suggested changes in main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As discussed in #3960, applying changes needed for the stable branch in main to minimize the differences between the two branches. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Michael Tautschnig <[email protected]> Co-authored-by: Carolyn Zech <[email protected]>
This was pushed into the stable branch. Closing. |
This PR is for testing CI with a version that uses the stable 1.85.1 release with RUSTC_BOOTSTRAP=1 instead of the nightly channel.
The base commit is bc134ce, which is the latest Kani commit that works with 1.85.1.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.