Configure generic foreign key relations respecting Django internals #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Wow, this new matrix schema is amazing! |
amureki
reviewed
Oct 28, 2025
Member
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
The change makes sense to me. Thanks for adding the tests too! 🙌
I added minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543
Describe the change
This PR updates how
model-bakeryselects which model to use to configure aContentTypeof a model's generic relation. The current behavior delegates the control to model itself, since it's updated to respect whatever is defined as theirGenericForeignKey.for_concrete_modelspecifies.PR Checklist