Clarify type annotation #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amureki
approved these changes
Mar 7, 2025
Member
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
Great, thanks @ducdetronquito for running extra checks and improving the annotations! 🏅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
Thanks for maintaining model bakery :)
I use pyright in strict mode to typecheck my codebases and using baker.make or baker.prepare fail to typecheck because
_save_kwargsandattrsare incomplete sinceDictis inferred asdict[Unknown, Unknown].I just made this little PR to clarify the type annotations for these two parameters.
Have a nice day 🌴