Fix #479 -- Make sure db_default is being considered
#502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary since this field attribute does not exist in Django versions older than 5.0
amureki
approved these changes
Sep 20, 2024
Member
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
Love it, thank you, Bernardo! 🫶
amureki
changed the title
amureki
changed the title
db_default is being considered
Member
Author
|
@amureki any instructions on how to fix the coverage issue on CI? This is kind of new to me, so I'm not familiar. |
Member
Yeah, after rebasing, it should upload coverage artifacts and show an html report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479
Describe the change
This PR changes the
Baker.generate_valuemethod to also consider the values configured inField.db_default.