feat!: change root package.json type to module#6078
Draft
mark-wiemer wants to merge 11 commits into
Draft
Conversation
b79b5cf to
f6be57c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
+ Coverage 78.83% 82.15% +3.31%
==========================================
Files 63 62 -1
Lines 4546 4566 +20
Branches 989 991 +2
==========================================
+ Hits 3584 3751 +167
+ Misses 962 815 -147 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Playwright ESM test is failing on Windows + Node 20.19.0, all other tests passing, haven't tested any other OS or Node version yet: |
3 tasks
mark-wiemer
commented
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
My version of #6034, rebased to reduce merge conflicts and respect Josh's fork
"type": "module"so we Mocha is now an ESM-first packagejsfiles tocjsandmjsfiles tojsoptions.mjsto CJS (options.cjs) due torewiremockusage and low ROI for implementing (risky!) replacementmjsfor clarity? Need alignment with Josh as other maintainerjsextensions aren't used in spaces where onlycjsis expected, e.g.npm run test-node:unit