Skip to content

chore: rollback devDep npm-run-all2 to v8 for Node 20#6040

Merged
mark-wiemer merged 1 commit into
mochajs:mainfrom
mark-wiemer:npm-run-all2-v8
Jun 8, 2026
Merged

chore: rollback devDep npm-run-all2 to v8 for Node 20#6040
mark-wiemer merged 1 commit into
mochajs:mainfrom
mark-wiemer:npm-run-all2-v8

Conversation

@mark-wiemer

@mark-wiemer mark-wiemer commented Jun 7, 2026

Copy link
Copy Markdown
Member

PR Checklist

Overview

v9 of this devDep has an undocumented breaking change of only supporting Node 22.22+

Ref #6019 and bcomnes/npm-run-all2#231

v9 has an undocumented breaking change of only supporting Node 22.22+

Ref mochajs#6019
Comment thread package-lock.json
@mark-wiemer mark-wiemer added this to the v12.0.0 milestone Jun 7, 2026

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-triggered the tests (#6042). Once this passes, ✅

@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.08%. Comparing base (a8ffaa9) to head (872a1e7).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6040   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files          63       63           
  Lines        4581     4581           
  Branches      978      978           
=======================================
  Hits         3577     3577           
  Misses       1004     1004           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer

Copy link
Copy Markdown
Member Author

Known test failures (#6036 and #6037 ), merging :)

@mark-wiemer mark-wiemer merged commit d7d095b into mochajs:main Jun 8, 2026
194 of 303 checks passed
@mark-wiemer mark-wiemer deleted the npm-run-all2-v8 branch June 8, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠️ Repo: npm i with Node 22.21.1 gives EBADENGINE for npm-run-all2

2 participants