feat: allow ^ versions for character encoding packages#5150
Merged
JoshuaKGoldberg merged 5 commits intomochajs:mainfrom Jul 2, 2024
Merged
Conversation
JoshuaKGoldberg
force-pushed
the
minor-versions-character-encoding-packages
branch
from
8d8af57 to
352b483
Compare
JoshuaKGoldberg
force-pushed
the
minor-versions-character-encoding-packages
branch
from
352b483 to
993c3a6
Compare
JoshuaKGoldberg
force-pushed
the
minor-versions-character-encoding-packages
branch
from
993c3a6 to
00a7f9f
Compare
JoshuaKGoldberg
added
the
semver-minor
voxpelli
requested changes
May 31, 2024
Member
voxpelli
left a comment
voxpelli
left a comment
There was a problem hiding this comment.
The one change looks indeed harmless: doowb/ansi-colors@4.1.1...4.1.3
But can you do a new npm install ansi-colors@^4.1.3 to ensure that our lockfile actually also references it?
JoshuaKGoldberg
commented
May 31, 2024
voxpelli
reviewed
Jun 4, 2024
Member
Author
|
Released in |
This was referenced Jul 28, 2024
This was referenced Aug 11, 2024
This was referenced Aug 11, 2024
This was referenced Aug 13, 2024
This was referenced Oct 23, 2024
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
* feat: allow ^ versions for character encoding packages * escape-string-regexp too * npm install ansi-colors@^4.1.3 * ...but keep package.json's dependencies entry the same * Updated to the latest ansi-colors per review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adds a
^range to the following packages related to character encoding in logs:ansi-colors: new minor versions available, up to4.1.3- which it's upgraded to nowbrowser-stdout: latest version; hasn't been updated in 6 yearsescape-string-regexp: no new minor versions available - just a new majorhe: latest version; hasn't been updated in 6 yearslog-symbols: no new minor versions available - just new majorssupports-color: no new minor versions available - just a new major