Skip to content

fix: nil pointer that happened twice in swarm stack. Rare occurrence. #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Nov 10, 2025
Merged

fix: nil pointer that happened twice in swarm stack. Rare occurrence. #3223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions manager/orchestrator/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ func SetServiceTasksRemove(ctx context.Context, s *store.MemoryStore, service *a
// within the boundaries of a transaction
latestTask := store.GetTask(tx, t.ID)

// in case the task is deleted
if latestTask == nil {
log.G(ctx).WithField("task_id", t.ID).Debug("task no longer exists in store")
return nil
}

// time travel is not allowed. if the current desired state is
// above the one we're trying to go to we can't go backwards.
// we have nothing to do and we should skip to the next task
Expand Down