Fixed a nil pointer that happened twice in swarm stack. Rare occurrence. #3222
Closed
frikky wants to merge 1 commit into
Closed
Fixed a nil pointer that happened twice in swarm stack. Rare occurrence. #3222frikky wants to merge 1 commit into
frikky wants to merge 1 commit into
Conversation
… store.GetTask() seem to be doing the check
Contributor
|
I will go ahead and fix DCO, then open another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store.GetTask() seems to have the nil pointer check in every other location we could find it to be used, so I'm sure this is just a small hiccup.
I don't really care if this PR is merged or if you clean it up on your side - the main thing is we need it fixed due to Swarm randomly crashing when you got hundreds of containers in many many services sending jobs back and forth. We have no clear way to reproduce it due to the goroutine madness.
Ref issue from first time it occurred: #3216