Add explicit support for macvlan networks to bash completion#24861
Merged
vdemeester merged 1 commit intomoby:masterfrom Jul 21, 2016
Merged
Add explicit support for macvlan networks to bash completion#24861vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Member
|
Should we add |
Member
Author
|
Could not find it in the release notes. Did it also exit experimental? |
Member
|
I think it did, but good question 😄 I'm running an experimental version, let me quickly check :) |
Member
Author
|
It's not in current master: root@8b3519213a48:~# docker network create -d ipvlan some-network
Error response from daemon: plugin not found
root@8b3519213a48:~# docker version
Client:
Version: 1.12.0-dev
API version: 1.25
Go version: go1.6.3
Git commit: a9ca19f
Built: Wed Jul 20 19:45:23 2016
OS/Arch: linux/amd64
Server:
Version: 1.12.0-dev
API version: 1.25
Go version: go1.6.3
Git commit: a9ca19f
Built: Wed Jul 20 19:45:23 2016
OS/Arch: linux/amd64 |
Member
|
Looks like you're right; it's only macvlan #23524 |
Member
|
LGTM! |
Member
|
LGTM 🐸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash completion grabs the available network drivers from the output of
docker info.Unfortionally, the
macvlannetwork driver will not appear there unless a network was created using it, see #24798 (comment).This PR explicitly adds this driver to the computed driver list so that it is always available.
Note that this is a workaround until the upcoming plugin system is available.
Please schedule for 1.12.0.