Problem with -v shared folders in 1.6

[dmenne]

System: Window 7/64

With:

Boot2Docker version 1.5.0, build master : a66bce5 - Tue Feb 10 23:31:27 UTC 2015 

docker run \
  -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
  hello-world

is a valid command. This is a simplified and function-less test version, see below for the "real" one. Note that /Dieter is a valid user, please replace for testing.

With

$ docker version
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): windows/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64

I could not find out how to define the path in -v; I tried several of the variants mentioned in the docs of 1.5 on shared folders.

$ docker run \
>   -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
>   hello-world
invalid value "c:\\Users\\Dieter\\Documents\\Gastrobase;C:\\Program Files (x86)\\Git\\home\\shiny\\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

---- Real application -------------

docker run --restart=always --name gastrobase -d -p 3838:3838 \
  -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
  dmenne/gastro-docker


Dieter@DIETERPC ~
$ docker run --restart=always --name gastrobase -d -p 3838:3838 \
>   -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
>   dmenne/gastro-docker
invalid value "c:\\Users\\Dieter\\Documents\\Gastrobase;C:\\Program Files (x86)\\Git\\home\\shiny\\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

[jessfraz]

I don't understand how this could be a regression when there was never a
docker client version you could run on windows before.

On Tuesday, April 21, 2015, Dieter Menne notifications@github.com wrote:

System: Window 7/64

With:

Boot2Docker version 1.5.0, build master : a66bce5 - Tue Feb 10 23:31:27 UTC 2015

docker run
-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
hello-world

is a valid command. This is a simplified and function-less test version,
see below for the "real" one. Note that /Dieter is a valid user, please
replace for testing.

With

$ docker version
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): windows/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64

I could not find out how to define the path in -v; I tried several of the
variants mentioned in the docs of 1.5 on shared folders.

$ docker run \

-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
hello-world
invalid value "c:\Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

---- Real application -------------

docker run --restart=always --name gastrobase -d -p 3838:3838
-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
dmenne/gastro-docker

Dieter@DIETERPC ~
$ docker run --restart=always --name gastrobase -d -p 3838:3838 \

-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
dmenne/gastro-docker
invalid value "c:\Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

—
Reply to this email directly or view it on GitHub
#12590.

[dmenne]

Maybe I should change the title to "Boot2Docker". And the -v parameter has the same --help documentation as before.

[calavera]

I don't think this is an issue parsing volumes in Docker, not really related to Boot2Docker itself. The volume path validation assumes that there is only one : in the string to separated host and container paths. In windows, that's not true.

See https://github.com/docker/docker/blob/master/opts/opts.go#L150

This test should expose the issue:

diff --git c/integration-cli/docker_cli_run_windows_test.go i/integration-cli/docker_cli_run_windows_test.go
new file mode 100644
index 0000000..53c69d6
--- /dev/null
+++ i/integration-cli/docker_cli_run_windows_test.go
@@ -0,0 +1,26 @@
+// +build windows
+
+package main
+
+import (
+       "fmt"
+       "io/ioutil"
+       "os"
+       "os/exec"
+
+       "github.com/docker/docker/vendor/src/github.com/go-check/check"
+)
+
+// Test that creating a container with a volume doesn't crash. See #12590
+func (s *DockerSuite) TestRunCreateVolumeAbsoluteWindowsPath(c *check.C) {
+       tmpDir, err := ioutil.TempDir("", "docker-test-container")
+       if err != nil {
+               c.Fatal(err)
+       }
+
+       defer os.RemoveAll(tmpDir)
+       cmd := exec.Command(dockerBinary, "run", "-v", fmt.Sprintf("%s:/tmp/docker-test-container", tmpDir), "busybox", "true")
+       if _, err := runCommand(cmd); err != nil {
+               c.Fatal(err)
+       }
+}

[ahmetb]

@calavera you're passing a windows path to -v in your test. That's not supported. Currently both parts of the -v should be unix paths because Docker engine is running on Linux.

[ahmetb]

@dmenne

If you're using git bash on windows, msysgit converts paths like /c/users to c:\users (not something you want because the path inside the boot2docker VM is /c/Users)

Try surrounding -v value with single quotes like:

... -v '/c/Users:/path' ...

On cmd.exe/powershell you shouldn't be having this problem. Does this solve the issue?

[calavera]

that makes sense, thanks @ahmetalpbalkan.

[dmenne]

I had tried the ' ' before, but the error message is the same in all cases:

docker run -v '/c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase'  hello-world

invalid value "c:\Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase" for flag -v: \Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path

Check the error message: for reasons I do not understand, the current msysgit path is appended to the evaluated value: C:\Program Files (x86)\Git\home\shiny\Gastrobase.

I admit that I was not successful testing it on cmd/Powershell. After setting the DOCKER_XXX variables and checking that the cert-path exists, I always get the "Are you trying to connect ... TLS" message. Setting SET DOCKER_TLS_VERIFY=0 did not help. Sorry if I missed something obvious.

[ahmetb]

@dmenne I think it's happening just because of the weird path interpretation of msysgit. In -v we separate paths with :, and : is also used as drive letter separator (as in c:) and that's why I think it's getting confused.

I'd just try turning that feature off if possible in msys window or try stuff like

... -v 'path1:'path2' ...

But that shouldn't be really an issue on windows consoles.

[dmenne]

-v 'path1:'path2'

I assume it's a typo, both paths should be in ''? I have tried both version with the same result, i.e. 'path1:path2' and 'path1':'path2'.

"Should not be an issue on windows consoles": But most people will use the default Boot2Docker console, I assume. And : I could not get the Windows consoles to work because of the dreaded TLS. I must have missed something in the docs.

[ahmetb]

@dmenne you're right. I'll take a look to make it better on msys. In order to make it work in Windows consoles, run "boot2docker shellinit" and paste the output to your console and it should work exactly the same as it was in b2d window.

[dmenne]

Confirmed. Everything works without errors in Powershell and cmd.
Thanks. Nevertheless, a fix for the msys-bug would be nice.

[brettp]

A hacky workaround for mysys is to use double leading slashes on the path:

docker run -v //c/Users/brettp/app:/app

[dmenne]

Krr... I thought I had tried that variant, but possible only with backslashes. Does not look hacky, but quite ok and works. Thank's for sharing. Could we put that into the docs of shared folders?