Skip to content

Reduce shelling out in tests - #64

Merged
thaJeztah merged 3 commits into
moby:mainfrom
thaJeztah:tar_no_shellout
Jul 23, 2026
Merged

Reduce shelling out in tests#64
thaJeztah merged 3 commits into
moby:mainfrom
thaJeztah:tar_no_shellout

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 22, 2026 01:00

This comment was marked as off-topic.

@thaJeztah
thaJeztah requested a review from Copilot July 22, 2026 01:00

This comment was marked as off-topic.

@codecov-commenter

codecov-commenter commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.52%. Comparing base (216738e) to head (0d250bd).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   65.81%   65.52%   -0.30%     
==========================================
  Files          42       42              
  Lines        2039     2039              
==========================================
- Hits         1342     1336       -6     
- Misses        519      522       +3     
- Partials      178      181       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
thaJeztah marked this pull request as draft July 22, 2026 01:06
Copilot AI review requested due to automatic review settings July 23, 2026 14:37

This comment was marked as off-topic.

Copilot AI review requested due to automatic review settings July 23, 2026 14:52

This comment was marked as off-topic.

Copilot AI review requested due to automatic review settings July 23, 2026 14:57

This comment was marked as off-topic.

Avoid shelling out to tar for this.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah marked this pull request as ready for review July 23, 2026 15:05
@thaJeztah
thaJeztah requested a review from vvoland July 23, 2026 17:41
@thaJeztah
thaJeztah merged commit 0bfb096 into moby:main Jul 23, 2026
12 checks passed
@thaJeztah
thaJeztah deleted the tar_no_shellout branch July 23, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants