remove some intermediate vars - #53
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 66.35% 65.50% -0.86%
==========================================
Files 42 42
Lines 2027 2035 +8
==========================================
- Hits 1345 1333 -12
- Misses 497 530 +33
+ Partials 185 172 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thaJeztah
changed the title
vvoland
reviewed
Jul 20, 2026
| whiteOutDir := filepath.Dir(change.Path) | ||
| whiteOutBase := filepath.Base(change.Path) | ||
| whiteOut := filepath.Join(whiteOutDir, WhiteoutPrefix+whiteOutBase) | ||
| whiteOut := filepath.Join(filepath.Dir(change.Path), WhiteoutPrefix+filepath.Base(change.Path)) |
Contributor
There was a problem hiding this comment.
To be honest, this is too dense. Previous was better IMO
Member
Author
There was a problem hiding this comment.
dropped the first commit
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.