Skip to content

add test to verify symlinks targets are preserved (skipped) - #48

Merged
thaJeztah merged 1 commit into
moby:mainfrom
thaJeztah:test_symlink
Jul 22, 2026
Merged

add test to verify symlinks targets are preserved (skipped)#48
thaJeztah merged 1 commit into
moby:mainfrom
thaJeztah:test_symlink

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Symlink targets are considered opaque and preserved as-is, even if it doesn't match the platform.

@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.13%. Comparing base (2cd730e) to head (bddbecd).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   66.35%   66.13%   -0.22%     
==========================================
  Files          42       32      -10     
  Lines        2027     1949      -78     
==========================================
- Hits         1345     1289      -56     
+ Misses        497      494       -3     
+ Partials      185      166      -19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
thaJeztah force-pushed the test_symlink branch 2 times, most recently from 92cb487 to bddbecd Compare July 16, 2026 11:45
@thaJeztah

Copy link
Copy Markdown
Member Author

Ugh, so that doesn't work; os.Symlink normalizes, and os.Root.Symlink doesn't;
https://go.dev/src/os/file_windows.go

// Symlink creates newname as a symbolic link to oldname.
// On Windows, a symlink to a non-existent oldname creates a file symlink;
// if oldname is later created as a directory the symlink will not work.
/ If there is an error, it will be of type *LinkError.
func Symlink(oldname, newname string) error {
  	// '/' does not work in link's content
  	oldname = filepathlite.FromSlash(oldname)

@thaJeztah thaJeztah closed this Jul 16, 2026
@thaJeztah
thaJeztah deleted the test_symlink branch July 16, 2026 17:19
@thaJeztah
thaJeztah restored the test_symlink branch July 22, 2026 12:07
@thaJeztah thaJeztah reopened this Jul 22, 2026
Copilot AI review requested due to automatic review settings July 22, 2026 12:08

This comment was marked as off-topic.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copilot AI review requested due to automatic review settings July 22, 2026 12:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@thaJeztah thaJeztah changed the title add test to verify symlinks targets are preserved add test to verify symlinks targets are preserved (skipped) Jul 22, 2026
@thaJeztah
thaJeztah merged commit 5bfe8d9 into moby:main Jul 22, 2026
12 checks passed
@thaJeztah
thaJeztah deleted the test_symlink branch July 22, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants