createImpliedDirectories: fix directory detection and path handling - #44
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 66.35% 65.25% -1.10%
==========================================
Files 42 42
Lines 2027 2035 +8
==========================================
- Hits 1345 1328 -17
- Misses 497 533 +36
+ Partials 185 174 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thaJeztah
marked this pull request as draft
July 15, 2026 15:00
The code used os.PathSeparator to detect if the Tar-header was not for a directory, but Tar headers use POSIX (forward-slashes), so this would fail on Windows. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
create_implied
branch
from
July 15, 2026 15:02
f2d75aa to
e45dc89
Compare
thaJeztah
marked this pull request as ready for review
July 15, 2026 15:21
vvoland
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code used os.PathSeparator to detect if the Tar-header was not for a directory, but Tar headers use POSIX (forward-slashes), so this would fail on Windows.