rename vars to prevent shadowing and for clarity - #39
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // #nosec G305 -- The joined path is guarded against path traversal. | ||
| path := filepath.Join(dest, hdr.Name) | ||
| rel, err := filepath.Rel(dest, path) | ||
| dstPath := filepath.Join(dest, hdr.Name) |
Member
Author
There was a problem hiding this comment.
existing issue; will be fixed elsewhere if needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 66.35% 64.89% -1.47%
==========================================
Files 42 42
Lines 2027 2031 +4
==========================================
- Hits 1345 1318 -27
- Misses 497 537 +40
+ Partials 185 176 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vvoland
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.