rename some vars to prevent shadowing "path" import - #35
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return breakoutError(fmt.Errorf("invalid symlink %q -> %q", dstPath, hdr.Linkname)) | ||
| } | ||
| if err := os.Symlink(hdr.Linkname, path); err != nil { | ||
| if err := os.Symlink(hdr.Linkname, dstPath); err != nil { |
There was a problem hiding this comment.
Yup; this needs fixing, but unrelated.
| @@ -861,25 +861,25 @@ loop: | |||
| // The only exception is when it is a directory *and* the file from | |||
| // the layer is also a directory. Then we want to merge them (i.e. | |||
| // just apply the metadata from the layer). | |||
There was a problem hiding this comment.
Yup; this needs fixing, but unrelated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 66.35% 65.04% -1.32%
==========================================
Files 42 42
Lines 2027 2031 +4
==========================================
- Hits 1345 1321 -24
- Misses 497 535 +38
+ Partials 185 175 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@AkihiroSuda if you have time for quick LGTM on this one; CodeQL failures are expected; I'm working on reviewing some of the other PRs related to that, so this is to make the way free for using |
| return breakoutError(fmt.Errorf("invalid hardlink %q -> %q", targetPath, hdr.Linkname)) | ||
| } | ||
| if err := os.Link(targetPath, path); err != nil { | ||
| if err := os.Link(targetPath, dstPath); err != nil { |
There was a problem hiding this comment.
kinda confusing to have both "targetPath" and "dstPath"
There was a problem hiding this comment.
Hm.. yeah, perhaps linkTarget for the existing one?
|
Alternatively |
|
Yeah, was considering that as alternative; that said, there's various places where Oh! Of course now needs a rebase 😂 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5 participants
No description provided.