use wrapper function instead of variable for freebsd - #3
Merged
Conversation
This variable made me look various times to find if it was (e.g.) needed to stub out the function in (unit)tests, but it looks like it was only there for convenience (not having to define a function). Let's change it to a regular function that wraps the underlying implementation to prevent this confusion. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
wrap_no_alias
branch
from
April 14, 2025 13:06
c404689 to
891de7e
Compare
vvoland
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable made me look various times to find if it was (e.g.) needed to stub out the function in (unit)tests, but it looks like it was only there for convenience (not having to define a function).
Let's change it to a regular function that wraps the underlying implementation to prevent this confusion.