Skip to content

Fix regression /run/buildkit is inaccessible for socket user#4619

Merged
crazy-max merged 1 commit into
moby:masterfrom
AkihiroSuda:fix-4618
Feb 6, 2024
Merged

Fix regression /run/buildkit is inaccessible for socket user#4619
crazy-max merged 1 commit into
moby:masterfrom
AkihiroSuda:fix-4618

Conversation

@AkihiroSuda

Copy link
Copy Markdown
Member

Fix #4618 (regression in v0.13.0-beta1)

Fix issue 4618 (regression in v0.13.0-beta1)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Comment thread cmd/buildkitd/main.go
os.RemoveAll(lockPath)
}()

// listeners have to be initialized before the controller

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is because newGRPCListeners() is responsible for mkdiring and chowning /run/buildkit.)

@tonistiigi tonistiigi requested a review from crazy-max February 6, 2024 04:08

@crazy-max crazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v0.13.0-beta1 regression] /run/buildkit is inaccessible for socket users

2 participants