Skip to content

error generating html report on schedule event #141

@crazy-max

Description

@crazy-max

relates to #123

Seems schedule event is not handled: https://github.com/moby/buildkit-bench/actions/runs/10977826935/job/30480698575#step:7:455

#22 [tests-gen-run 3/3] RUN --mount=type=bind,target=. <<EOT (set -e...)
#22 0.058 + gotestmetrics gen --output /tmp/benchmarks.html --name 20240922-034541 --candidates /tests-results/candidates.json --config /tests-results/testconfig.yml --gha-event /tests-results/gha-event.json --envs /tests-results/env.txt --validation-mode strict '/tests-results/gotestoutput*.json'
#22 0.063 Merging 13 benchmark results file(s)
#22 0.063 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildEmulator.json
#22 0.065 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildFileTransfer.json
#22 0.066 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildHighParallelization128x.json
#22 0.067 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildHighParallelization16x.json
#22 0.068 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildHighParallelization32x.json
#22 0.069 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildHighParallelization64x.json
#22 0.069 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildMultistage.json
#22 0.070 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildRemote.json
#22 0.072 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildSecret.json
#22 0.073 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkBuild-BenchmarkBuildSimple.json
#22 0.074 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkDaemon-BenchmarkDaemonSize.json
#22 0.074 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkDaemon-BenchmarkDaemonVersion.json
#22 0.075 Loading benchmark results from file /tests-results/gotestoutput-BenchmarkPackage-BenchmarkPackageSize.json
#22 0.076 Validating 312 benchmark results based on /tests-results/testconfig.yml
#22 0.076 Generating HTML report to /tmp/benchmarks.html
#22 0.077 gotestmetrics: error: unknown X-Github-Event in message: schedule

Can't see it on module's code we are using: https://github.com/google/go-github/blob/46f1127c50024fd92c7bb10992e1baaf607ee5e7/github/messages.go#L48-L115

I guess this makes sense as schedule is only triggered on default branch and is very much similar to a "push" event but we miss info to display result metadata in the event payload:

{
  "schedule": "*/10 * * * *"
}

I guess we need to rely on envs for such event.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions