Skip to content

Use the stable Condvar API #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented May 14, 2020

Switch to use wait_while and wait_timeout_while as the outcome of
rust-lang/rust#67076 removed wait_until and
wait_timeout_until. Switches the predicate logic around.

@rjwalters
Copy link
Contributor

Thanks for this contribution! For the time being, we are using the nightly-2019-12-19 rust toolchain so the new Condvar interface is not available to us yet. This decision is driven by recent changes in 32 bit iOS support in rust-lang and our desire to support SDK development on older iPhones, like the iPhone 5. This PR will likely have to wait until we drop support for these older devices.

@dvdplm
Copy link
Contributor Author

dvdplm commented May 14, 2020

Ah, that was the missing piece of info, thank you for that. Feel free to close or leave it open until the time comes, as you prefer. :)

@rjwalters rjwalters closed this Jul 6, 2020
@rjwalters rjwalters force-pushed the chore/use-stable-condvar-api branch from 5d31bdd to 12fa004 Compare July 6, 2020 23:18
@rjwalters
Copy link
Contributor

@dvdplm - my attempt to rebase your PR resulted in it being closed... we actually just updated our rust toolchain so I was attempting to get your patch ready to merge. Perhaps you can reopen it?

@eranrund
Copy link
Contributor

eranrund commented Jul 6, 2020

@rjwalters The changes here were already implemented by @jcape in #264

@rjwalters
Copy link
Contributor

@rjwalters The changes here were already implemented by @jcape in #264

perhaps that's why it ended up closing the PR?

Thanks again @dvdplm for contributing to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants