[Feature] Cover JSON schema string format #141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase to the latest main since we just force-pushed it. See #177 (comment) for more info. |
cyx-6
force-pushed
the
json-schema-format
branch
from
fa8049f to
f1979d5
Compare
benchislett
reviewed
Mar 7, 2025
| RegexToEBNF(relative_json_pointer_regex_pattern, false); | ||
| return "\"\\\"\" " + relative_json_pointer_ebnf + " \"\\\"\""; | ||
| } | ||
| } |
There was a problem hiding this comment.
You should probably remove the "format" key in WarnUnsupportedKeywords below
There was a problem hiding this comment.
Sure. Actually some sub-types in "format" are still missing, e.g. iri and idn-email. Maybe we need to notify in detail.
benchislett
reviewed
Mar 7, 2025
Thanks for asking this. I think so, and I am working on it recently. The main problem for this PR is the generated bnf from these format parameter could run slow; I am working on enhancing the efficiency. |
|
Moved to #266. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the most string formats in JSON schema, except "idn-email", "idn-hostname", "iri", and "iri-reference".