Skip to content

[Metal] Fix depthwise conv 1D kernel name for large variant#3289

Merged
angeloskath merged 1 commit intoml-explore:mainfrom
mlx-node:fix/depthwise-conv-1d-kernal-name
Mar 23, 2026
Merged

[Metal] Fix depthwise conv 1D kernel name for large variant#3289
angeloskath merged 1 commit intoml-explore:mainfrom
mlx-node:fix/depthwise-conv-1d-kernal-name

Conversation

@Brooooooklyn
Copy link
Contributor

The kernel name was constructed with the wrong argument order, producing depthwise_conv_1d__largefloat16 instead of depthwise_conv_1d_float16_large which matches the Metal kernel registration.

The kernel name was constructed with the wrong argument order, producing
`depthwise_conv_1d__largefloat16` instead of `depthwise_conv_1d_float16_large`
which matches the Metal kernel registration.
Copy link
Collaborator

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! What was happening when calling the kernel, did it always get JIT compiled?

@Brooooooklyn
Copy link
Contributor Author

What I got:

❯ node index.js

[MLX] Exception in async_eval: [metal::Device] Unable to load kernel depthwise_conv_1d__largebfloat16

[MLX] Exception in mlx_qwen35_moe_eval_token_and_caches: [metal::Device] Unable to load kernel depthwise_conv_1d__largebfloat16

[MLX] Exception in array_eval: [metal::Device] Unable to load kernel depthwise_conv_1d__largebfloat16

[1] 32912 segmentation fault  node index.js

@angeloskath angeloskath merged commit e40ada3 into ml-explore:main Mar 23, 2026
16 checks passed
@Brooooooklyn Brooooooklyn deleted the fix/depthwise-conv-1d-kernal-name branch March 24, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants