Fix long cache file path on Windows#3065
Merged
zcbenz merged 1 commit intoml-explore:mainfrom Jan 26, 2026
Merged
Conversation
angeloskath
reviewed
Jan 26, 2026
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
That's pretty cool but out of curiosity what do we lose by simply using a smaller max_file_name_length ? Or was that actually not solving the issue at all?
Collaborator
Author
|
The |
angeloskath
approved these changes
Jan 26, 2026
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
I see. Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding
\\?\before file paths we can makestd::filesystemAPIs support long file path on Windows.https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
Also add
.ilkfile (output of MSVC) to.gitignore, and slightly organize the.gitignorefile.