Added clarification to apply_fn parameter of apply_to_modules#2831
Merged
awni merged 3 commits intoml-explore:mainfrom Nov 26, 2025
Merged
Added clarification to apply_fn parameter of apply_to_modules#2831awni merged 3 commits intoml-explore:mainfrom
awni merged 3 commits intoml-explore:mainfrom
Conversation
Clarified the apply_fn argument in the docstring to include details about its parameters.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified the apply_fn argument in the docstring to include details about its parameters.
Proposed changes
When creating a transformer architecture using MLX and working on weight initialization, I had to read the source code of apply_to_modules to understand what apply_fn expects as its input parameters. Modified the doctoring to add clarification in the documentation.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes