[CUDA] Support array mask in SDPA#2822
Merged
zcbenz merged 1 commit intoml-explore:mainfrom Nov 26, 2025
Merged
Conversation
awni
approved these changes
Nov 25, 2025
Member
awni
left a comment
There was a problem hiding this comment.
Looks great!
As a general guideline we should work towards avoiding in dispatching differently based on the back-end because it breaks the ability to exporting from machine to another (e.g. export on cuda would not work on Metal). The fast primitives are one place where we break this guideline a lot (e.g. cpu vs gpu). Just elaborating for future reference as we may want to push the mask -> float into the primitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that cuDNN does not support boolean masks, so we have to convert boolean masks to additive masks with
where(mask, full_like(mask, 0), full_like(mask, -inf)), which has some performance penalty. (PyTorch does the same thing too.)What cuDNN does support is setting padding mask directly: we pass the sequence lengths and cuDNN will apply padding masks automatically, and it works together with the
set_causal_maskflag. I don't know how much performance gain this approach brings, but I think it worths a try as a future work.