shellbags fix#320
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for childless shellbag entries from #268
The fix detects subkeys that don't have corresponding numbered values and creates entries with
shell_type: "Childless"andfirst_interactedtimestamp from the subkey's last_write time.Note: The current test hives don't contain childless entries, so this code path isn't exercised by validation tests. If anyone has a sample NTUSER.DAT hive with childless shellbag entries, please share it so we can add proper validation coverage.
--
Made sure validation test yield same results to make sure no functionality was lost